Add conversions between enumerations and associated values #159
+114
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
macdrevx
reviewed
Oct 4, 2021
macdrevx
reviewed
Oct 4, 2021
macdrevx
reviewed
Oct 4, 2021
macdrevx
reviewed
Oct 4, 2021
macdrevx
reviewed
Oct 4, 2021
Contributor
macdrevx
left a comment
macdrevx
left a comment
There was a problem hiding this comment.
I feel really comfortable with the GeometryConvertible and GeoJSONObjectConvertible portions of this PR. It's less obvious whether the JSONValueConvertible portions are what we want. If there's a way to defer those parts, I think it'd be worth taking the extra time.
This was referenced Oct 5, 2021
1ec5
force-pushed
the
1ec5-geojson-convertible-158
branch
from
16fa18c to
53910de
Compare
Contributor
Author
|
I split out the |
macdrevx
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added protocol-based initializers to
GeometryandGeoJSONObjectthat accept each case’s associated value as an initializer argument. This makes the enumerations more consistent with theJSONValueandFeatureIdentifierenumerations and simplifies some common workflows.JSONValue and FeatureIdentifier now conform to the
Hashableprotocol. These types are likely to be used as dictionary keys or set members, and it’s pretty easy to make them hashable.Fixes #158.
/cc @mapbox/navigation-ios @mapbox/maps-ios